Conversation
gmelodie
force-pushed
the
gabe/restify-contents-api
branch
from
4a754d1 to
eebc00d
Compare
gmelodie
force-pushed
the
gabe/restify-contents-api
branch
from
e3b1bec to
689fdfc
Compare
|
@gmelodie Could we have the car files be passed through formData rather than through the body to be more consistent with how regular files are added |
| e.POST("/contents", withUser(s.handleAdd), s.AuthRequired(util.PermLevelUpload)) | ||
|
|
||
| contents := e.Group("", s.AuthRequired(util.PermLevelUser)) | ||
| contents.GET("/contents", withUser(s.handleListContent)) |
There was a problem hiding this comment.
Shouldn't these be behind /api/v2 ?
anjor
left a comment
anjor
left a comment
There was a problem hiding this comment.
We should not delete the v1 endpoints. They should still be around. The new endpoints should be under a v2 path.
Separately, I think uploadType should be an enum
|
@kelindi I'm trying not to change too much. I think it's about balance. |
|
@gmelodie I think it would add some more consistency when uploading a file, which would be better for dx. If I am understanding it correctly, the current route you have is the same no matter the file and then it figures out what the case is based on the file? If that is the case it would make more sense to have the request be formatted the same when uploading a regular file or a car file. |
|
No the user has to specify the upload type, it's not inferred . |
|
Closing in favor of #716 |
4 participants
Addresses #583
Verification
Add CAR, add to bucket (new name for collections) and dir too
1.2. List that bucket on that dir to see the file
Add CID, add to bucket and dir too
2.2. List that bucket on that dir to see the pinned file
Getting the status of one of the contents
Get content by CID
